Post-Processing Invites #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gets0ul
commented
Mar 19, 2020
gets0ul
commented
- change maskInviteEmails to postProcessInvites which will be post-processing on invite(s) with following constraints:
- email field will be omitted from invite if the invite has defined userId
- email field (if existed) will be masked UNLESS current user has admin permissions OR current user created this invite
- also apply this post-processing when creating invite.
…ocessing on invite(s) with following constraints: 1. email field will be omitted from invite if the invite has defined userId 2. email field (if existed) will be masked UNLESS current user has admin permissions OR current user created this invite - also apply this post-processing when creating invite.
maxceem
suggested changes
Mar 20, 2020
There was a problem hiding this comment.
@gets0ul we have to mask email if it's not "null" UNLESS current user has admin permissions OR current user created this invite which means req.authUser.userId === invite.createdBy not req.authUser.email === invite.email.
In other words, if Bob invites Alice by "email" he can still see the email of Alice because it was he who created this invite.
As a result of this logic:
- Create invite endpoint would always return emails without masking even though we apply post-processor. So unit tests of create invite endpoint should check that email is always returned without mask (when we invite by email, when by the handle, email suppose to be not returned).
- I just understand that if invite failed, we don't have
createdBy, so please, don't apply post-processor to thefailedarray.
- I just understand that if invite failed, we don't have
- Please, add one more unit test to create invite endpoint: email should not be returned for invites by a handle to non-admin users
maxceem
reviewed
Mar 20, 2020
maxceem
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.